What's new
  • SNBForums Code of Conduct

    SNBForums is a community for everyone, no matter what their level of experience.

    Please be tolerant and patient of others, especially newcomers. We are all here to share and learn!

    The rules are simple: Be patient, be nice, be helpful or be gone!

MerlinAU MerlinAU v1.4.1 - The Ultimate Firmware Auto-Updater (GNUTON SUPPORT!)

You could also do like Skynet and if you see the script is not installed upon running, set the install argument within the script to force an install.

I like it, it's better than my workaround method now; I'll help myself to implementing something similar.
Thanks for the suggestion dave!
 
OK some feedback and some minor quibbles...
01 - OK
Happy to see I fixed that report for you :)

02 - Quibble. You cannot have 1.4.1 offering an update to .... 1.4.1; nor can it be "available" for download if you have it already running.

Ah; I see the bug, it's no longer downloading the version.txt when it used too. It may be related to PR: 433: https://github.com/ExtremeFiretop/MerlinAutoUpdate-Router/pull/433 or it may not; just a gut feeling.
I'll investigate, thanks for reporting!

03 - Request. After you set the Router PWD a flag that is has been done and is successful would be useful?

I'll keep it in mind for sure once we smooth out the update for everyone ;)

04 - The 5. Toggle seems gramatically incorrect and does not behave in any case, Issue.

Unable to recreate this with a fresh install, did you happen to keep your configuration file when uninstalling?
If so, please delete it and re-test and advise, if not, please provide an example of the configuration file (remember to blank out the password/credentials)

05 - The 3. Toggle seems OK.

Okay - What about the previous toggle you reported? Is it fixed now? (The tailscale toggle)

How do I revert to the mainstream install btw?

This will get you back to the production 1.4.0:
Code:
sh /jffs/scripts/MerlinAU.sh stable
 
Happy to see I fixed that report for you :)
Sorry I forgot to say thank you :). Getting a wee bit tired here,,,
Ah; I see the bug, it's no longer downloading the version.txt when it used too. It may be related to PR: 433: https://github.com/ExtremeFiretop/MerlinAutoUpdate-Router/pull/433 or it may not; just a gut feeling. I'll investigate, thanks for reporting!
Coolio.
I'll keep it in mind for sure once we smooth out the update for everyone ;)
Coolio.
Unable to recreate this with a fresh install, did you happen to keep your configuration file when uninstalling?
If so, please delete it and re-test and advise, if not, please provide an example of the configuration file (remember to blank out the password/credentials)
First time I kept it, second time I uninstalled and deleted it, then reinstalled, Screencaps from run 2,.
Okay - What about the previous toggle you reported? Is it fixed now? (The tailscale toggle)
Lol, I was wondering what happened to 4, I thought you snuck in another number and shifted them all one to see if I was awake.... it's on page "ad... "
Apart from an odd initial question, I think it's working but the colours are inverted which is confusing me no end ,,,
This will get you back to the production 1.4.0:
Code:
sh /jffs/scripts/MerlinAU.sh forceupdate
Cheers
 

Attachments

  • 06.jpg
    06.jpg
    109.9 KB · Views: 9
  • 07_Colours Inverted.jpg
    07_Colours Inverted.jpg
    60.8 KB · Views: 8
  • 08.jpg
    08.jpg
    95.9 KB · Views: 5
  • 09.jpg
    09.jpg
    92.4 KB · Views: 7
Lol, I was wondering what happened to 4, I thought you snuck in another number and shifted them all one to see if I was awake.... it's on page "ad... "
Apart from an odd initial question, I think it's working but the colours are inverted which is confusing me no end ,,,

Cheers

So basically your still having the bug with the changelog check? Is that correct? Could you provide me your configuration file? Just make sure to blank out the credentials please.
As for your question as to why disabled is green and enabled is red, is because green is the default choice for the script for that setting. By default people should have it disabled (green) unless absolutely required in which case the user selects "enabled (red)" which is not the default/ideal choice.
 
So basically your still having the bug with the changelog check? Is that correct?
Just testing it again, Seems to behave, apart from the first run question, if it is currently enabled, why is the first question "proceed to enable" and not "proceed to disable?"
Could you provide me your configuration file? Just make sure to blank out the credentials please.
Where do I find that file please?
As for your question as to why disabled is green and enabled is red, is because green is the default choice for the script for that setting. By default people should have it disabled (green) unless absolutely required in which case the user selects "enabled (red)" which is not the default/ideal choice.
OK I see. It is a wee bit counter to the other options so for me a "Default=Disabled" reminder here would go some way to clarifying that :-).
 

Attachments

  • 13.jpg
    13.jpg
    57.7 KB · Views: 5
  • 12.jpg
    12.jpg
    62.1 KB · Views: 5
  • 11.jpg
    11.jpg
    64.9 KB · Views: 4
  • 10.jpg
    10.jpg
    72 KB · Views: 5
Just testing it again, Seems to behave, apart from the first run question, if it is currently enabled, why is the first question "proceed to enable" and not "proceed to disable?"

Thats a bug for sure; thats what I'm trying to figure out, with my version from the dev branch with a fresh install it works fine:

1744042138441.png


Where do I find that file please?

Use:
Code:
cat /jffs/addons/MerlinAU.d/custom_settings.txt

OK I see. It is a wee bit counter to the other options so for me a "Default=Disabled" reminder here would go some way to clarifying that :-).

I can add that to the list as well :)
 
Thats a bug for sure; thats what I'm trying to figure out, with my version from the dev branch with a fresh install it works fine:

View attachment 64841

Use:
Code:
cat /jffs/addons/MerlinAU.d/custom_settings.txt

I can add that to the list as well :)

FW_New_Update_Notification_Date TBD
FW_New_Update_Notification_Vers TBD
FW_New_Update_Postponement_Days=15
FW_New_Update_EMail_Notification DISABLED
FW_New_Update_EMail_FormatType="HTML"
FW_New_Update_Cron_Job_Schedule="20 0 * * *"
FW_New_Update_ZIP_Directory_Path="/home/root"
FW_New_Update_LOG_Directory_Path="/jffs/addons"
FW_Update_Check ENABLED
CheckChangeLog ENABLED
FW_New_Update_Changelog_Approval="TBD"
 
FW_New_Update_Notification_Date TBD
FW_New_Update_Notification_Vers TBD
FW_New_Update_Postponement_Days=15
FW_New_Update_EMail_Notification DISABLED
FW_New_Update_EMail_FormatType="HTML"
FW_New_Update_Cron_Job_Schedule="20 0 * * *"
FW_New_Update_ZIP_Directory_Path="/home/root"
FW_New_Update_LOG_Directory_Path="/jffs/addons"
FW_Update_Check ENABLED
CheckChangeLog ENABLED
FW_New_Update_Changelog_Approval="TBD"

Your sure your testing with the version from the dev branch? Between uninstalling and reinstalling? And deleting the configuration file?
That configuration file is missing a lot of values.

Code:
curl --retry 3 "https://raw.githubusercontent.com/ExtremeFiretop/MerlinAutoUpdate-Router/refs/heads/dev/MerlinAU.sh" -o "/jffs/scripts/MerlinAU.sh" && chmod 755 "/jffs/scripts/MerlinAU.sh"

I made another change to implement @dave14305 's recommendation as well for handling the install parameter situation in PR 444 : https://github.com/ExtremeFiretop/MerlinAutoUpdate-Router/pull/444
 
Your sure your testing with the version from the dev branch? Between uninstalling and reinstalling? And deleting the configuration file?
Yes. I uninstalled and said trash the config, I used the same curl dev install each run, it wouldn’t say 1.4.1 otherwise would it 😃
That configuration file is missing a lot of values.
I know; but the issues with the other items shouldn’t be dependent on these being populated or ?
Code:
curl --retry 3 "https://raw.githubusercontent.com/ExtremeFiretop/MerlinAutoUpdate-Router/refs/heads/dev/MerlinAU.sh" -o "/jffs/scripts/MerlinAU.sh" && chmod 755 "/jffs/scripts/MerlinAU.sh"

I used the one you gave me in the post above. Seems the same?
I made another change to implement @dave14305 's recommendation as well for handling the install parameter situation in PR 444 : https://github.com/ExtremeFiretop/MerlinAutoUpdate-Router/pull/444
Ok will try tomorrow it’s 1:15am … zzzzz thanks 🙏
 
Yes. I uninstalled and said trash the config, I used the same curl dev install each run, it wouldn’t say 1.4.1 otherwise would it 😃

My question is whether or not your latest output is from 1.4.1; considering the configuration output doesn't say 1.4.1 and you didn't specify in the reply, I need to ask for clarity.
Considering your uninstalling and reinstalling, it's easy to keep the configuration file for another version of the script, or reinstall the wrong version by mistake when providing the output.

I know; but the issues with the other items shouldn’t be dependent on these being populated or ?

What issues with other items? As of this moment from my last PR, my only thing remaining is your changelog check.
My configuration file looked like your empty one before my very first PR, since my first PR, it's been fully populated on every clean install; which is why I ask for clarity above considering it wasn't provided.

I used the one you gave me in the post above. Seems the same?

Yes they are the same, I am re-providing it for you to test my latest changes, the URL will not change.
 
Last edited:
OK some feedback and some minor quibbles...
01 - OK
02 - Quibble. You cannot have 1.4.1 offering an update to .... 1.4.1; nor can it be "available" for download if you have it already running.
03 - Request. After you set the Router PWD a flag that is has been done and is successful would be useful?
04 - The 5. Toggle seems gramatically incorrect and does not behave in any case, Issue.
05 - The 3. Toggle seems OK.

How do I revert to the mainstream install btw?
sh /jffs/scripts/MerlinAU stable
 
Ok will try tomorrow it’s 1:15am … zzzzz thanks 🙏

I'm taking a break myself now... I poked for a bit longer; but I can't replicate the issue with the configuration file anymore since my PRs, I'm getting a bit of headache so I'll step away for a bit and wait too see if Martinski has any more ideas or feedback.

To clarify my last reply above, the reason I continued poking if you are on 1.4.1 and deleted the configuration file between tests is simply because it's easy to miss, and as I mentioned in my reply; I did have the problem with the configuration file, and no longer have it on my side since my latest PRs.

Even when downgrading back to the current 1.4.0 I have the issue again. This to me quickly confirms I'm on the right track; but you seem to still have issue.

My only answer right now is the configuration file remained as a bug or user error, or I'm completely barking up the wrong tree and my results are just a red herring distracting from something else.

For example, the uninstall specifically requires a "Y" and then a "N" selection to delete the confirmation file... However if your expecting a "Yes" to confirm uninstalling and then a "Yes" to confirm "trashing" the configuration file you will be caught off guard when that's not how it functions.. it's "Yes" to uninstall and "No" to preserving the file which could be an easy miss for example. Another example is you mentioned you weren't sure where the file was which means a visual confirmation may not have been done that the file is indeed missing between tests (even if you may have selected to delete the file, it could have remained as a bug for example).

It's not to be annoying that I circle back to these points, it's only to verify the information collected is complete, and understood correctly on both sides.
 
What issues with other items? As of this moment from my last PR, my only thing remaining is your changelog check.
Hi again,

First off I have to apologise for being a bit short last night, I re-read the sequence of my responses and I came across as increasingly snarky, which was uncalled for, especially given you were just trying to help out. It was late and I was tired and was juggling a few things but that is no excuse; it was rude and for that I sincerely apologise.

For example, the uninstall specifically requires a "Y" and then a "N" selection to delete the confirmation file... However if your expecting a "Yes" to confirm uninstalling and then a "Yes" to confirm "trashing" the configuration file you will be caught off guard when that's not how it functions.. it's "Yes" to uninstall and "No" to preserving the file which could be an easy miss for example. Another example is you mentioned you weren't sure where the file was which means a visual confirmation may not have been done that the file is indeed missing between tests (even if you may have selected to delete the file, it could have remained as a bug for example).
You may be right about the Y, N sequence, in my hurry I may have inadvertently selected 'Y', 'Y'.

So, I went through the sequence again, this time pausing to check keystrokes between my entries. I have attached some screenshots which hopefully show the required 'Y', 'N' sequence for a complete uninstall and deletion of the settings file. The absence of a custom_settings.txt file in MerlinAU.d, indeed the absence of a MerlinAU.d dir at all, in jffs/addons/ both suggests it is definitely gone.

It's not to be annoying that I circle back to these points, it's only to verify the information collected is complete, and understood correctly on both sides.
Totally understood, your tenacity is admirable :-).

I am still seeing some 'TBD' in the custom_settings.txt (although I think they are expected?), one of them I think is because I do not have an external drive (USB) attached (although I did enable DC in amtm, for future use). The others are items that MerlinAU does on a schedule, that have simply not run yet?

I think I am still seeing an oddity with the wording of a couple of these i.e.
  1. ['ad', 4 togggle Tailscale/ZerTier]; whereby it shows (first run), the item being Enabled in the menu, but if I say "N" to enable, it says it REMAINS disabled (which it never was in the first place?)
  2. [main menu, 5, Toggle Changelog]; whereby it shows (first run), the item being enabled in the menu, but when you select enable it says it is "now" enabled? Semantics? For this one, after I changed it via y, 'enabled' (even though it was already shown as enabled?) the changelog verification check I saw the last two lines added in custom_settings.txt:

Code:
FW_New_Update_Notification_Date TBD
FW_New_Update_Notification_Vers TBD
FW_New_Update_Postponement_Days=15
FW_New_Update_EMail_Notification ENABLED
FW_New_Update_EMail_FormatType="HTML"
FW_New_Update_Cron_Job_Schedule="20 0 * * *"
FW_New_Update_ZIP_Directory_Path="/home/root"
FW_New_Update_LOG_Directory_Path="/jffs/addons"
FW_Update_Check ENABLED
credentials_base64 <DELETED>
FW_Allow_Beta_Production_Up ENABLED
Allow_Updates_OverVPN DISABLED
CheckChangeLog ENABLED
FW_New_Update_Changelog_Approval="TBD"

I am not sure if this helps you at all as I have gone through the menus testing things in a somewhat haphazard fashion, but if you would like me to run a specific sequence to narrow it down, that you can replicate e.g. uninstall > install dev via curl > toggle menu in a very specific order > screencaps, let me know and I will see what I can do to help you replicate it (if you do see these as bugs).

Thanks again for the amazing addon and your support of it!
 

Attachments

  • 13-14.jpg
    13-14.jpg
    108 KB · Views: 4
  • 15-16.jpg
    15-16.jpg
    93.6 KB · Views: 6
  • 17-18.jpg
    17-18.jpg
    107 KB · Views: 5
  • 19-20.jpg
    19-20.jpg
    106.6 KB · Views: 6
  • 21-22.jpg
    21-22.jpg
    119.7 KB · Views: 8
Last edited:
Hi again,

First off I have to apologise for being a bit short last night, I re-read the sequence of my responses and I came across as increasingly snarky, which was uncalled for, especially given you were just trying to help out. It was late and I was tired and was juggling a few things but that is no excuse; it was rude and for that I sincerely apologise.

Hi @jksmurf

No need to apologize, communication is tricky to get right over text, I personally didn't really take anything as snarky.
I was more starting to get the feeling you were annoyed that I circled back to that question again; I felt the need to clarify my viewpoint why I did that.

You may be right about the Y, N sequence, in my hurry I may have inadvertently selected 'Y', 'Y'.

So, I went through the sequence again, this time pausing to check keystrokes between my entries. I have attached some screenshots which hopefully show the required 'Y', 'N' sequence for a complete uninstall and deletion of the settings file. The absence of a custom_settings.txt file in MerlinAU.d, indeed the absence of a MerlinAU.d dir at all, in jffs/addons/ both suggests it is definitely gone.

Awesome! With this confirmation and with these screenshots I have the *confidence* to say my results are likely a red herring; and I can move on and bark up other areas of the code.
I appreciate you taking the time to help clarify these points for me so we have a proper understanding of your issue and testing preformed.

I am still seeing some 'TBD' in the custom_settings.txt (although I think they are expected?), one of them I think is because I do not have an external drive (USB) attached (although I did enable DC in amtm, for future use). The others are items that MerlinAU does on a schedule, that have simply not run yet?

This is great; it gives me a good sense of the state of things after a clean install in your configuration file, which very clearly shows the issue is still there for you.
As you identified, the TBD values in the configuration file is expected, I am not so concerned with the TBD as much as the missing values all together; for example this is my fresh install:
Code:
FW_New_Update_Notification_Date TBD
FW_New_Update_Notification_Vers TBD
FW_New_Update_Postponement_Days=15
FW_New_Update_EMail_Notification DISABLED
FW_New_Update_EMail_FormatType="HTML"
FW_New_Update_Cron_Job_Schedule="0 0 * * *"
FW_New_Update_ZIP_Directory_Path="/tmp/mnt/USB3"
FW_New_Update_LOG_Directory_Path="/jffs/addons"
FW_New_Update_LOG_Preferred_Path="/jffs/addons"
credentials_base64 TBD
CheckChangeLog ENABLED
FW_Update_Check ENABLED
Allow_Updates_OverVPN DISABLED
FW_Allow_Beta_Production_Up ENABLED
Allow_Script_Auto_Update DISABLED
Script_Update_Cron_Job_SchedDays="* x *"
FW_Auto_Backupmon ENABLED

You'll notice when comparing to yours in your screenshot; it is missing many values and appears to stop following mine above at around this line:
FW_New_Update_LOG_Preferred_Path=
This may be a clue; I have a gut feeling what might be happening here... I'll have to test again and discuss with Martinski.

I think I am still seeing an oddity with the wording of a couple of these i.e.
  1. ['ad', 4 togggle Tailscale/ZerTier]; whereby it shows (first run), the item being Enabled in the menu, but if I say "N" to enable, it says it REMAINS disabled (which it never was in the first place?)
  2. [main menu, 5, Toggle Changelog]; whereby it shows (first run), the item being enabled in the menu, but when you select enable it says it is "now" enabled? Semantics? For this one, after I changed it via y, 'enabled' (even though it was already shown as enabled?) the changelog verification check I saw the last two lines added in custom_settings.txt:

Code:
FW_New_Update_Notification_Date TBD
FW_New_Update_Notification_Vers TBD
FW_New_Update_Postponement_Days=15
FW_New_Update_EMail_Notification ENABLED
FW_New_Update_EMail_FormatType="HTML"
FW_New_Update_Cron_Job_Schedule="20 0 * * *"
FW_New_Update_ZIP_Directory_Path="/home/root"
FW_New_Update_LOG_Directory_Path="/jffs/addons"
FW_Update_Check ENABLED
credentials_base64 <DELETED>
FW_Allow_Beta_Production_Up ENABLED
Allow_Updates_OverVPN DISABLED
CheckChangeLog ENABLED
FW_New_Update_Changelog_Approval="TBD"

I am not sure if this helps you at all as I have gone through the menus testing things in a somewhat haphazard fashion, but if you would like me to run a specific sequence to narrow it down, that you can replicate e.g. uninstall > install dev via curl > toggle menu in a very specific order > screencaps, let me know and I will see what I can do to help you replicate it (if you do see these as bugs).

This was definitely helpful; I took a dinner and a nap and headache is gone so I'm ready to poke at this again with some fresh eyes, give me a bit of time to review with fresh eyes and hopefully I'll have found something shortly.

Thanks again for the amazing addon and your support of it!

No thank you for reporting these issues, frankly we need users to report these abnormities; since as you can see even when testing not everything is black and white, sometimes issues are a little harder to track down if they can't be replicated.
(This issue I've tried on both my test devices to replicate for example)
 
Last edited:
This may be a clue; I have a gut feeling what might be happening here... I'll have to test again and discuss with Martinski.
All good stuff, thanks @ExtremeFiretop. Let's see where it goes after you follow it through, there's no hurry on this at all btw.
 
Last edited:

Attachments

  • Waiting.jpg
    Waiting.jpg
    75.8 KB · Views: 5
Ready and waiting ...

Awesome, thank you for this. I follow most of Martinski's PR except for one area which I need clarification on.
I've still merged it in, please test with the same command and advise if the fresh install functions better:

Code:
curl --retry 3 "https://raw.githubusercontent.com/ExtremeFiretop/MerlinAutoUpdate-Router/refs/heads/dev/MerlinAU.sh" -o "/jffs/scripts/MerlinAU.sh" && chmod 755 "/jffs/scripts/MerlinAU.sh"

Martinski removed my install parameter solution from his PR, so that means you will need to manually run that until @thelonelycoder merges the changes on his side.
sh /jffs/scripts/MerlinAU.sh install
 
Not sure what this means?

Sorry it didn't get tagged as code in the last reply:

Code:
sh /jffs/scripts/MerlinAU.sh install
 

Support SNBForums w/ Amazon

If you'd like to support SNBForums, just use this link and buy anything on Amazon. Thanks!

Sign Up For SNBForums Daily Digest

Get an update of what's new every day delivered to your mailbox. Sign up here!

Staff online

Back
Top