qos-start settings lost after web setting update

[sfatula]

Perhaps there is another script I should also be running qos-script from?

So, if I reboot the router, I see my settings from qos-script, works perfectly. Now, I go into the web management for the router, update something, router save settings, and, my qos settings are gone. So, the script is not rerun. Presumably, it is only run at startup.

Is there another user script from which I should run my script? Perhaps there is a script triggered by a saving of the settings?

 

[RMerlin]

It depends on what you are entering in that script. It only gets executed when the QoS rules get applied. If you do any changes to, for example, the firewall, then anything that restarts the firewall would wipe your changes.

 

[sfatula]

So, I add a new QOS rule in the web interface, click apply, and, all my custom QOS rules go away. It does not rerun the qos-start script.

Shouldn't there be a way for that script to be run again without manually executing it?

 

[RMerlin]

So, I add a new QOS rule in the web interface, click apply, and, all my custom QOS rules go away. It does not rerun the qos-start script.

Shouldn't there be a way for that script to be run again without manually executing it?

Make sure you do press on the "+" icon on the webui when adding a new rule.

I haven't had any other report of issues with the QoS page.

 

[sfatula]

I do, it's easy to see. I do:

iptables -L QOSO -t mangle --line-numbers

I see my rules that were inserted via qos-start

Now, I add a new rule in the web interface, click +, click apply, wait, go to to a ssh session, do the same command:

iptables -L QOSO -t mangle --line-numbers

And, my inserted rules are now gone. Therefore, it did not re-execute qos-start.

I think it should do so.

 

[RMerlin]

I do, it's easy to see. I do:

iptables -L QOSO -t mangle --line-numbers

I see my rules that were inserted via qos-start

Now, I add a new rule in the web interface, click +, click apply, wait, go to to a ssh session, do the same command:

iptables -L QOSO -t mangle --line-numbers

And, my inserted rules are now gone. Therefore, it did not re-execute qos-start.

I think it should do so.

From what I can see, Asus has two different functions to setup QoS. One, which only runs at boot time, takes care of configuring the tc tables. That's where I run qos-start.

The second function which gets run if you modify rules on the webui, only deals with iptables. This one does not contain a qos-start script.

Since applying settings on the webui restarts both QoS and the firewall, I would advise for now to put your rules into firewall-start. I'll have to figure out what kind of problems could arise from having qos-start run both in the initial start_qos() and the other function that only gets called when settings are modified.

 

[RMerlin]

I finally settled on the following solution:

When qos-start is run, it will get an argument passed to it. That argument will either be "init" (meaning QoS is getting initialized, and only the tc settings have been configured) or "rules" (which means iptables rules are being configured). So your script will have to check if $1 contains either "init" or "rules", and react accordingly.

 

[sfatula]

Seems reasonable. I just tested firewall-start and it does work at least when changing settings. Thanks for your help!

I am starting to love this router, and firmware.