thelonelycoder
Part of the Furniture
Sounds like an interesting feature and if built in, it would make sense to expand this to the whitelist as well.I thought about a feature yesterday. To purge our blacklist file from time to time it could be useful to show similar between the hosts file which are downloaded and our blacklist.txt
For instance if i ad some ads to my blacklist file as it's not present on stevenblack one and i add it on stevenblack after on github. What do you think about thelonelycoder ?
But I have my doubts such a purge is useful and helpful for the longer term.
Domains are added to the list because some app or website is not working as it should.
Changing the blocking file type may then include or exclude the domain, but you still want that domain in the list in case it is added or removed from the hosts file .
Example: I add baddomain.com to the blacklist because of reasons and it is not included in the current blocking file I use.
One day, baddomain.com is added to one of the hosts files. Good, I can remove it from the blacklist --> done.
Scenario:
1. I change the blocking file type and baddomain.com is not included in it --> ugh, better re-add it to the blacklist.
2. The maintainer decides to remove baddomain.com from the hosts file --> ugh, better re-add it to the blacklist.
The same applies for the whitelist. You added it for a specific reason and always want that domain whitelisted, no matter what the hosts file maintainers do or what blocking file type you select.
Since both lists are domains you added for a specific reason I'd rather not have it purged by an automatism that does not take into consideration the reason why it was added in the first place.
Having baddomain.com in the blocking file and the blacklist is no problem at all. Dnsmasq will block it as soon as it finds it in one of the lists, omitting the second instance in the other.
Usually, the white/blacklist is a relatively small file. My blacklist has about 400 entries while the whitelist only has about 50.
And as a final note to this, the hosts files sizes change considerably over time.
With each update of the ab-solution.sh, I have to significantly increase the domain count and file size for the blocking file types.
So, in my conclusion, this change may not be welcome at all, but I'm always open for suggestions and improvements if they make sense. Or users can convince me with good reasons to add it.