@bigeyes0x0: I think I found some minor things and I have a feature request.
First of all, when keeping settings while updating and using dnscrypt-proxy.log is active, the installer script gives an error (at least, I think it's because of dnscrypt-proxy.log, as it's on the next line):
Code:
Info: Migrating log_file with value 'dnscrypt-proxy.log'
[: 267: unknown operand
It also seems that when choosing to keep settings which have been manually edited in dnscrypt-proxy.toml, the installer has some issues putting them back in the right place in dnscrypt-proxy.toml when I decide to keep my previous settings:
Code:
15. ##################################
16. # Global settings #
17. ##################################
18.
19. log_file = 'dnscrypt-proxy.log'
20.
21. daemonize = true
22.
23. cert_ignore_timestamp = true
*Line numbers added by me.
I'm not sure how critical the .toml format is about finding the variables at the corresponding lines in the config file?
When looking through to dnscrypt-proxy.toml I noticed that the dnscrypt-proxy.log is completely ignored, it's still hashed out at line
Code:
92. ## log file for the application
93.
94. # log_file = 'dnscrypt-proxy.log'
* Line numbers added by me.
Also, modified settings for query.log and nx.log are apparently ignored when keeping previous settings:
Code:
205. [query_log]
206.
207. ## Path to the query log file (absolute, or relative to the same directory as the executable file)
208.
209. # file = 'query.log'
...
231. [nx_log]
232.
233. ## Path to the query log file (absolute, or relative to the same directory as the executable file)
234.
235. # file = 'nx.log'
*Line numbers added by me.
All three variables mentioned previously where un-hashed (?) prior to running the latest version of the installer script, and selecting to keep previous settings, but where not retained after finishing configuring.
As for the feature request: Would it be possible if I select to keep my settings and wish to keep using OpenDNS IP updating, that I don't have to enter my credentials every time the script is updated? Just but minor thing, but it would be convenient. When using randomized 16-20 character passwords, it's sometimes a pain to have to re-enter them as I need to look them up in Lastpass and can't see what I'm entering
.
Having said that, the installer works otherwise like a charm, great to see how it evolved over the past few weeks. Sure has made things a lot easier
, thank you!
EDIT: Link to full dnscrypt-proxy.toml:
https://pastebin.com/wNpWsXYr