Error in changing machine's icon

[Le_Sage]

Hello,

I found a bug in firmware 380.59 on my RT-AC66U (think it's the same in 380.61 because no mention in change log for that bug).
In Local network -> DHCP server -> Manually assigned IP address DHCP list :
When you click on a machine icon to change the icon, if the device name have an ' (=apostrophe) then you can't change the icon because of the javascript which invoke the select_image function. Here for example the generated code which i've on the Advanced_DHCP_Content.asp page :
<td id="tbCardClientListIcon0"><div class="type1" onclick="select_image(this.className,'Micro-star int'l co., ltd.');" title="Windows device"></div></td>
So like you can see device name "Micro-star int'l co.,ltd." have an ' (and i can't change it.) so i can't change the icon.

 

[RMerlin]

The changelog only includes my own changes, it doesn't include Asus's own changes. You will have to test it to determine if the issue is still there or not.

 

[Le_Sage]

OK, but i don't want to test now because i've seen that after flash 380.60 and up, that we can not roll back, so i keep the 380.59 that work very well for me...
I've forgotten to say that i've seen the error since the beginning I've my router (so the same bug with the 380.56, 380.57, 380.58 and 380.59 firmware)
And last but not least i've programmed a patch (in javascript) to correct this bug, it's for GreaseMonkey in FireFox. If someone interested....

 

[Le_Sage]

Hi all,
I re-up this thread because today i've received my new RT-AC88U, and guess what... There is the same problem even with the last fw 384.7_2

 

[RMerlin]

I've made the webui escape apostrophes found in device vendor names when generating the select_image() calling code.

Ideally, these should be filtered out within networkmap (which is no longer in my control). Otherwise, it means we might run into other code situations where vendor names containing quotes might cause problems (I know it's not the first instance I've fixed so far).