Problem with "View List" on Network Map page

[seanford]

Been this way for a while now...

It's a javascript error...console output below...

client_function.js:2415 Uncaught TypeError: Cannot read property 'isWebServer' of undefined(…)
drawClientListBlock @ client_function.js:2415
doSorter @ client_function.js:1941
sorterClientList @ client_function.js:2082
(anonymous function) @ VM2462:1

 

[pete y testing]

have you tried another browser as the view list works here

 

[RMerlin]

It's an old bug, which in 6 months of attempts, I have only been able to reproduce a single time here, so I've been unable to track it down. Based on user feedback it seems it might be specific to Firefox.

380.64 will include a fix for Firefox, maybe it will help with this issue as well - hard to say, not knowing exactly the root cause.

 

[Giorgio]

Hi, I tracked down the issue with the original firmware, don't know if it's the same (where can I submit pull request for the original fw?), it's looking for a lowercase MAC in an array with uppercase indexes.
This fixes it on the original FW: client_function.js, line 2407:
FROM

clientListCode += (clientList[clientlist_sort[j].mac].isWebServer) ? "<a class='link' href='http://"+clientlist_sort[j].ip+"' target='_blank'>"+clientlist_sort[j].ip+"</a>" : clientlist_sort[j].ip;

TO

clientListCode += (clientList[clientlist_sort[j].mac.toUpperCase()].isWebServer) ? "<a class='link' href='http://"+clientlist_sort[j].ip+"' target='_blank'>"+clientlist_sort[j].ip+"</a>" : clientlist_sort[j].ip;

EDIT: nevermind, found this one http://www.snbforums.com/threads/ne...-list-and-other-issues-editing-devices.27474/

 

[RMerlin]

Hi, I tracked down the issue with the original firmware, don't know if it's the same (where can I submit pull request for the original fw?)

Asus does not provide the firmware code over a repository, as they have many separate code branches, and also because they work on code that contains private code - the GPL tarballs must be specially prepared.

I fixed one instance of mismatched case last year. If there's another place that can generate an incorrect case, it needs to be fixed at the source rather than hack a blanket toUpper() in every single location where the array might get accessed.

 

[GregS]

FYI, I've got a similar problem but I don't believe the issue is due to upper/lower casing:

Uncaught SyntaxError: Unexpected token c in JSON at position 0
at JSON.parse (<anonymous>)
at http://192.168.1.1/client_function.js:78:30
at http://192.168.1.1/client_function.js:95:3
client_function.js:326

That line is: var store = (win.name ? JSON.parse(win.name) : {});\

If I instead click View List instead of the round button above it I also get this:
Uncaught TypeError: Cannot read property 'fromDHCPLease' of undefined(…)genClientList @ client_function.js:326
create_clientlist_listview @ client_function.js:2220
pop_clientlist_listview @ client_function.js:2006
onclick @ index.asp:2196

This used to work until about a month ago. Around that time I upgraded to the latest firmware (380.63_2) and have had new devices connecting to the network. I've never manually entered mac addresses but I have added names for each device. The Asus android app does show my full device list and appears to be fully functional so I'll use that for now.

 

[GregS]

Never mind, a power cycle resolved my issue; previously I had only done reboots.

 

[RMerlin]

Uncaught SyntaxError: Unexpected token c in JSON at position 0

That specific error is fixed in 380.64.

 

[GregS]

Nice, didn't even know there was a new version; updating now