Adamm
Part of the Furniture
I think what happens is that Banmalware doesn't run anymore right after reboot, as before this Skynet version, I could see in the log the Skynet message every hour (assuming the router rebooted 5am, the skynet was starting fine and the message was every hour, 6am, 7am, etc), but now, after rooboot, I cannot see that message anymore, for example, the router reboots at 5, then there is no message anymore until I manually run the Banmalware. After that, the message is back there every hour... until next reboot.
Nothing in the startup or save functions have been altered in months, so I think we need to look outside the box.
Anyways, this is 10 minutes after router reboot:
It seems to me that this issue may be specific to the (closed source) XWRT firmware. The fact Skynet isn't initiated for 10 minutes after a reboot throws up some red flags (this happens almost immediately on Asus devices)
Some other possibilities may be that the USB you have Skynet installed to (or possibly another script?) is deleting the Skynet files located in "/tmp/mnt/abs/skynet" during the boot process. Maybe the USB is corrupt or something of that nature, hard to say.
But with the output you posted above, the save function is working as expected and saving changes to "/tmp/mnt/abs/skynet/scripts/ipset.txt". With that being said, either this file is being deleted during boot or the ipset restore function isn't working as expected. Considering the way banmalware functions using this and your output above shows it working, the latter is much less likely.
I suggest the following;
1). Uninstall then reinstall Skynet
2). When reinstalling Skynet, try install it to JFFS and see if the issue persists. That way we can rule out USB related issues.