[SOLVED] Cronjob parse error

[octopus]

I get parse error when execute script with cronjob but not with ssh.

Apr 28 18:44:01 crond[863]: user octopus: parse error at down
Apr 28 18:44:01 crond[863]: user octopus: parse error at *19

Get error with cronjob

cru a myfile down "0 *18 * * * /jffs/myfile.sh down"

But not with ssh

cru a myfile down "0 *18 * * * /jffs/myfile.sh down

I use myfile.sh down/up
what have i missed in this config?

Octopus

 

[RMerlin]

I see no space between "*" and "18". That's not a valid parameter.

 

[octopus]

I see no space between "*" and "18". That's not a valid parameter.

Thanks

I have set space between * and 18 and crone is execute.
But i still have parse error.
i use myfile.sh down to execute my .sh file

Apr 29 11:00:01 crond[863]: user octopus: parse error at down

case "$1" in
  down)
       content 1
    ;;

  down-1)

       content 2
    ;;

    up)

       content 3
    ;;

    up-1)

       content 4
    ;;

     *)

 

[ColinTaylor]

Do you have a shebang at the beginning of your script?

 

[octopus]

Do you have a shebang at the beginning of your script?

yepp shebang is on top of it.

 

[john9527]

Check that it somehow didn't get changed to DOS/Windows format with carriage returns.

dos2unix myfile.sh

 

[octopus]

Check that it somehow didn't get changed to DOS/Windows format with carriage returns.
dos2unix myfile.sh

I always make my script with Notepad++ with EOL-conversion to Unix.

Thanks

 

[john9527]

I know it's only a code snip....but did you close your 'case' selection with an 'esac'?

 

[octopus]

I know it's only a code snip....but did you close your 'case' selection with an 'esac'?

Yes i have this in end of script.

 echo "usage: $0 {down : down-slow | up : up-slow}"
  exit 0
esac

 

[ColinTaylor]

Got it!

The syntax of your "cru" command is wrong and putting rubbish in the crontab

# cru a myfile down "0 *18 * * * /tmp/zzz.sh down"

# cru l
30 6 * * * /sbin/service restart_wireless #RestartWireless#
00 6 * * * /jffs/scripts/adblock.sh /tmp/mnt/VERBATIM/ASUS #AdBlock#
down 0 *18 * * * /tmp/zzz.sh down #myfile#

# tail /tmp/syslog.log
Apr 30 01:46:01 crond[382]: user admin: parse error at down
Apr 30 01:46:01 crond[382]: user admin: parse error at *18

Try this:

cru l

then use "cru d myfile" to delete the incorrect entry, then

cru a myfile-down "0 18 * * * /jffs/myfile.sh down"

 

[octopus]

Got it!

The syntax of your "cru" command is wrong and putting rubbish in the crontab

# cru a myfile down "0 *18 * * * /tmp/zzz.sh down"

# cru l
30 6 * * * /sbin/service restart_wireless #RestartWireless#
00 6 * * * /jffs/scripts/adblock.sh /tmp/mnt/VERBATIM/ASUS #AdBlock#
down 0 *18 * * * /tmp/zzz.sh down #myfile#

# tail /tmp/syslog.log
Apr 30 01:46:01 crond[382]: user admin: parse error at down
Apr 30 01:46:01 crond[382]: user admin: parse error at *18

Try this:

cru l

then use "cru d myfile" to delete the incorrect entry, then

cru a myfile-down "0 18 * * * /jffs/myfile.sh down"

TANK YOU!!!

Thats working just fine, no more parse error. Can use up and down now.
Must use Hyphen (between myfile and down.)

Apr 30 13:46:01 crond[863]: crond: USER octopus pid 8656 cmd /jffs/configs/wanblock.sh down
Apr 30 13:50:01 crond[863]: crond: USER octopus pid 8720 cmd /jffs/configs/wanblock.sh up

Octopus