YazFi YAZFI error on johns fork version "3.0.0.4.374.43_46E8j9527"

[SkyCityCZ]

YazFi
v4.1.4
Updated 2020-08-16

Feature expansion of guest WiFi networks on AsusWRT-Merlin, including, but not limited to:

* Dedicated VPN WiFi networks
* Separate subnets for organisation of devices
* Restrict guests to only contact router for ICMP, DHCP, DNS, NTP and NetBIOS
* Allow guest networks to make use of pixelserv-tls (if installed)
* Allow guests to use a local DNS server
* Extend DNS Filter to guest networks

This project is hosted on GitHub

YazFi is free to use under the GNU General Public License version 3 (GPL 3.0).

Love the script and want to support future development? Any and all donations gratefully received!
PayPal donation
Buy me a coffee

Supported Models
Models
All modes supported by Asuswrt-Merlin. Models confirmed to work are below:

• RT-AC56U
• RT-AC66U
• RT-AC68U
• RT-AC86U
• RT-AC87U (2.4GHz guests only)
• RT-AC88U
• RT-AC3100
• RT-AC3200
• RT-AC5300
• RT-AX88U (clientisolation is not supported and is forced to false)

Firmware versions
Core YazFi features
You must be running firmware no older than:

• Asuswrt-Merlin 384.5
• john9527 fork 374.43_32D6j9527

WebUI page for YazFi
You must be running firmware no older than:

• Asuswrt-Merlin 384.15

Installation
Using your preferred SSH client/terminal, copy and paste the following command, then press Enter:

/usr/sbin/curl --retry 3 "https://raw.githubusercontent.com/jackyaz/YazFi/master/YazFi.sh" -o "/jffs/scripts/YazFi" && chmod 0755 /jffs/scripts/YazFi && /jffs/scripts/YazFi install

Please then follow instructions shown on-screen. An explanation of the settings is provided in the FAQs in post #2

Usage
To launch the YazFi menu after installation, use:

YazFi

If you do not have Entware installed, you will need to use the full path:

/jffs/scripts/YazFi

Updating
Launch YazFi and select option u

Hello Jack (and everyone else on here),
Sorry for messaging you and others here potentially making you busy guys but when i try to install YAZIFI on newest johns fork i get this error:

YazFi: Welcome to YazFi v4.1.4, a script by JackYaz

YazFi: Checking your router meets the requirements for YazFi

YazFi: Router does not support xt_comment module for iptables. Is a newer firmware available?

YazFi: John's fork detected - service-event requires 374.43_32D6j9527 or later

YazFi: Please update to benefit from YazFi detecting wireless restarts

YazFi: Requirements for YazFi not met, please see above for the reason(s)


Im using fork version "3.0.0.4.374.43_46E8j9527" any idea why it is doing that? (tried installing through amtm)

Thanks for any replies in advance guys and have a great day!

 

[ColinTaylor]

What model of router do you have?

 

[SkyCityCZ]

What model of router do you have?

RT-AC66U

 

[ColinTaylor]

It looks like the module check in YazFi isn't appropriate for John's firmware.

# modprobe xt_comment
modprobe: module xt_comment not found in modules.dep
# iptables -t nat -I POSTROUTING -s 2.2.2.2/24 -o tun11 -m comment --comment "TEST" -j MASQUERADE
# iptables-save | grep TEST
-A POSTROUTING -s 2.2.2.0/24 -o tun11 -m comment --comment TEST -j MASQUERADE
# iptables -t nat -D POSTROUTING -s 2.2.2.2/24 -o tun11 -m comment --comment "TEST" -j MASQUERADE

You could comment out the check in the script.

 

[SkyCityCZ]

It looks like the module check in YazFi isn't appropriate for John's firmware.

# modprobe xt_comment
modprobe: module xt_comment not found in modules.dep
# iptables -t nat -I POSTROUTING -s 2.2.2.2/24 -o tun11 -m comment --comment "TEST" -j MASQUERADE
# iptables-save | grep TEST
-A POSTROUTING -s 2.2.2.0/24 -o tun11 -m comment --comment TEST -j MASQUERADE
# iptables -t nat -D POSTROUTING -s 2.2.2.2/24 -o tun11 -m comment --comment "TEST" -j MASQUERADE

You could comment out the check in the script.

That fixed it, thanks!

 

[Jack Yaz]

It looks like the module check in YazFi isn't appropriate for John's firmware.

# modprobe xt_comment
modprobe: module xt_comment not found in modules.dep
# iptables -t nat -I POSTROUTING -s 2.2.2.2/24 -o tun11 -m comment --comment "TEST" -j MASQUERADE
# iptables-save | grep TEST
-A POSTROUTING -s 2.2.2.0/24 -o tun11 -m comment --comment TEST -j MASQUERADE
# iptables -t nat -D POSTROUTING -s 2.2.2.2/24 -o tun11 -m comment --comment "TEST" -j MASQUERADE

You could comment out the check in the script.

is there a better check you can recommend?

 

[ColinTaylor]

is there a better check you can recommend?

I couldn't think of one. AFAICT "comment" is built-in and not a loadable module in John's firmware. Maybe @john9527 can provide some insight.

 

[Jack Yaz]

I couldn't think of one. AFAICT "comment" is built-in and not a loadable module in John's firmware. Maybe @john9527 can provide some insight.

maybe it's a legacy check i no longer need!

 

[john9527]

maybe it's a legacy check i no longer need!

I couldn't think of one. AFAICT "comment" is built-in and not a loadable module in John's firmware. Maybe @john9527 can provide some insight.

iptables 'comment' was added as part of the kernel in V17
Maybe some confusion with ipset 'comment', which came in V26 and only available on ARM?

 

[mintoo]

Yesterday I installed the 374.43_49E4j9527 firmware to my RT-AC56U (thanks john9527 for your work). Before that, I had and used Merlin for several years. I did the updates mainly for YazFi, but unfortunately I can't install it. I do this via amtm and get the message:

YazFi: Welcome to YazFi v4.2.0, a script by JackYaz
YazFi: Checking your router meets the requirements for YazFi
YazFi: Router does not support xt_comment module for iptables. Is a newer firmware available?
YazFi: John's fork detected - service-event requires 374.43_32D6j9527 or later
YazFi: Please update to benefit from YazFi detecting wireless restarts

I would like to block lines in the script as @ColinTaylor advises. Will this method do nothing wrong with YazFi installation? Are there any other ways to install YazFi on this fork?

 

[john9527]

RMerlin implemented xt_comment as a module, in my fork it's compiled as part of the kernel. A little 'hackish', but replacing the check line with the following should detect either case. @Jack Yaz

if ! modprobe xt_comment 2>/dev/null && ! iptables -m comment 2>&1 | grep -q "comment:"; then

 

[mintoo]

I have never installed add-ons on a router before. Should I add this line to the file (which?). If so, does it matter where - the beginning or the end?
I'm a child of M$ Windows.

 

[ColinTaylor]

I have never installed add-ons on a router before. Should I add this line to the file (which?). If so, does it matter where - the beginning or the end?
I'm a child of M$ Windows.

If you just want a quick and dirty hack to get it installed while waiting for Jack to make a more permanent fix you'll need to download the script and edit it to change or remove the offending code.

To download the script:

/usr/sbin/curl --retry 3 "https://raw.githubusercontent.com/jackyaz/YazFi/master/YazFi.sh" -o "/jffs/scripts/YazFi"

Make it executable:

chmod 0755 /jffs/scripts/YazFi

Edit the file with your preferred editor, e.g.

nano /jffs/scripts/YazFi

Remove (or amend as described previously) this section of code at about line #1952:

        if ! modprobe xt_comment 2>/dev/null; then
                Print_Output true "Router does not support xt_comment module for iptables. Is a newer firmware available?" "$ERR"
                CHECKSFAILED="true"
        fi

Save the file and then run it:

/jffs/scripts/YazFi install

 

[mintoo]

It worked, thanks.