Scribe Installing on John's fork

[elorimer]

I've moved my 56U over from 384.6 to E7 of John's fork so as to be able to use the GUI addons. (Just reunited with this router after a year).

Scribe fails to install. It detects that diversion and skynet are both present, and then exits (deleting itself) as a failed install. Not sure what is going on here.

Anyone come across this?

 

[john9527]

Looks like you are the first to try and install Scribe on my fork
A quick look says the firmware level check code will fail running on my fork. I suspect it will work if the check is updated.

For a quick test, change

# router details
readonly merlin="ASUSWRT-Merlin"
readonly fwreqd="380.68"

to

# router details
readonly merlin="ASUSWRT-Merlin-LTS"
readonly fwreqd="374.43"

There's actually another part that should be tested, but this would tell if it works as is on the latest fork code.

 

[elorimer]

Yes, thanks, it worked a charm on my 56U. @cmkelley, you might think about adding this to your list. I might drag back into use my N16 to see what happens.

I moved from 384.6 to your fork because I wanted to add some of the @Jack Yaz GUI scripts, and the security enhancements. amtm was quite willing to give it a go. I can see a few things that aren't working well, including the DHCP replacement page and the QOS stuff.

Thanks!!

EDIT: Noticing that the 87U is somewhat orphaned here; not eligible for your fork, and not eligible for the @Jack Yaz scripts.

 

[john9527]

I thought Scribe would work....thanks for checking that one out!

I can see a few things that aren't working well, including the DHCP replacement page and the QOS stuff.

Both of those are VERY different between my fork and the latest Merlin. DHCP could probably be made to work without too much trouble (on my fork everything is just in nvram, not nvram/jffs). QoS is so different it really isn't applicable (no Adaptive QoS on the fork).

 

[Jack Yaz]

Yes, thanks, it worked a charm on my 56U. @cmkelley, you might think about adding this to your list. I might drag back into use my N16 to see what happens.

I moved from 384.6 to your fork because I wanted to add some of the @Jack Yaz GUI scripts, and the security enhancements. amtm was quite willing to give it a go. I can see a few things that aren't working well, including the DHCP replacement page and the QOS stuff.

Thanks!!

EDIT: Noticing that the 87U is somewhat orphaned here; not eligible for your fork, and not eligible for the @Jack Yaz scripts.

87u should be OK, I'd have to check the changelog history to see if it got the addons API. I don't really test on version number anymore but feature set

 

[Jack Yaz]

I thought Scribe would work....thanks for checking that one out!



Both of those are VERY different between my fork and the latest Merlin. DHCP could probably be made to work without too much trouble (on my fork everything is just in nvram, not nvram/jffs). QoS is so different it really isn't applicable (no Adaptive QoS on the fork).

YazDHCP uses a rewritten version of the Merlin DHCP page. I imagine it has a few references that don't apply in fork world. I have a 68U i can forkify and check it out. I imagine the backend stuff is fine, i test for jffs/nvram conditionally as Merlin does things differently depending on the model

 

[cmkelley]

Yes, thanks, it worked a charm on my 56U. @cmkelley, you might think about adding this to your list. I might drag back into use my N16 to see what happens.

I moved from 384.6 to your fork because I wanted to add some of the @Jack Yaz GUI scripts, and the security enhancements. amtm was quite willing to give it a go. I can see a few things that aren't working well, including the DHCP replacement page and the QOS stuff.

Thanks!!

EDIT: Noticing that the 87U is somewhat orphaned here; not eligible for your fork, and not eligible for the @Jack Yaz scripts.

So, here's the thing. I hazily recall there was a reason for setting 380.68 as the lowest, but whatever it was is either lost to me, or I'm misremembering and there wasn't a reason other than I copied it from someone else's code. Troubleshooting weird stuff in regular Merlin has proven difficult enough, while I'm sure John's fork is thoroughly awesome, I'm reluctant to enable using it, as it would pretty much be "here it is, good luck!"

That said, I do realize I've more or less abandoned scribe over the past year, but there is a huge amount going on in my life, and coding isn't even close to my day job. So enabling John's Fork would more or less just be adding to the abandonware. I'd not be at all fussed if someone forked scribe and took over maintaining it. It honestly does all I want it to do, and accomplished its primary mission, which was me learning how to write shell scripts. I do not accept donations for scribe for a reason.

 

[elorimer]

I've only noticed two things I'm still trying to track down.

1. When I first go to uiScribe, all the logs are open and except for the messages log, empty. If I close them all and reopen them, they all display properly.

2. I'm having some difficulty with the rewrite template in adding the time a message is processed, rather than the time logged. Works fine on my 86U.

 

[Jack Yaz]

I've only noticed two things I'm still trying to track down.

1. When I first go to uiScribe, all the logs are open and except for the messages log, empty. If I close them all and reopen them, they all display properly.

2. I'm having some difficulty with the rewrite template in adding the time a message is processed, rather than the time logged. Works fine on my 86U.

for 1 check for browser console errors. I'm not able to test on john's fork at the moment as my 68u is being used to test vnstat1 to vnstat2 migration

 

[elorimer]

Failed to load resource: the server responded with a status of 404 (Not Found) validator.js:1
Failed to load resource: the server responded with a status of 404 (Not Found) validator.js:1
Main_LogStatus_Content.asp:84 Uncaught ReferenceError: cookie is not defined
    at GetCookie (Main_LogStatus_Content.asp:84)
    at HTMLTableSectionElement.<anonymous> (Main_LogStatus_Content.asp:84)
    at Function.each (jquery.js:2)
    at S.fn.init.each (jquery.js:2)
    at AddEventHandlers (Main_LogStatus_Content.asp:84)
    at Object.success (Main_LogStatus_Content.asp:84)
    at c (jquery.js:2)
    at Object.fireWith [as resolveWith] (jquery.js:2)
    at l (jquery.js:2)
    at XMLHttpRequest.<anonymous> (jquery.js:2)

However, if I Hide then Show a log, it appears fine.

 

[Jack Yaz]

Failed to load resource: the server responded with a status of 404 (Not Found) validator.js:1
Failed to load resource: the server responded with a status of 404 (Not Found) validator.js:1
Main_LogStatus_Content.asp:84 Uncaught ReferenceError: cookie is not defined
    at GetCookie (Main_LogStatus_Content.asp:84)
    at HTMLTableSectionElement.<anonymous> (Main_LogStatus_Content.asp:84)
    at Function.each (jquery.js:2)
    at S.fn.init.each (jquery.js:2)
    at AddEventHandlers (Main_LogStatus_Content.asp:84)
    at Object.success (Main_LogStatus_Content.asp:84)
    at c (jquery.js:2)
    at Object.fireWith [as resolveWith] (jquery.js:2)
    at l (jquery.js:2)
    at XMLHttpRequest.<anonymous> (jquery.js:2)

However, if I Hide then Show a log, it appears fine.

looks like my cookie handling code acting up on page load. I'll take a look when I can

 

[john9527]

Failed to load resource: the server responded with a status of 404 (Not Found) validator.js:1
Failed to load resource: the server responded with a status of 404 (Not Found) validator.js:1

May be fallout from this error. On my fork, the validation functions are part of a shared javascript module. On Merlin, they got moved to their own module and some were renamed.
I took a quick look, and didn't see any obvious dependencies if I were to just include this library in the fork build so it could be accessed by any addons. I'll do a build and put it up as a Development download.

EDIT: Update-49D2 available in the Development-Beta folder

 

[elorimer]

49D2 breaks the GUI entirely for me but otherwise the router is functioning.

 

[john9527]

49D2 breaks the GUI entirely for me but otherwise the router is functioning.

???? Please give some additional details. (check the console again)
I'm running it on my AC68U without any problems.

 

[elorimer]

Neither Chrome nor Firefox are showing console errors. I think I will use the restoration tool to roll back and then have another go.

EDIT: I unplugged the router and let it sit. It's come back up on D2 fine.

The log behavior remains the same, although the first two console errors are gone:

Main_LogStatus_Content.asp:84 Uncaught ReferenceError: cookie is not defined
    at GetCookie (Main_LogStatus_Content.asp:84)
    at HTMLTableSectionElement.<anonymous> (Main_LogStatus_Content.asp:84)
    at Function.each (jquery.js:2)
    at S.fn.init.each (jquery.js:2)
    at AddEventHandlers (Main_LogStatus_Content.asp:84)
    at Object.success (Main_LogStatus_Content.asp:84)
    at c (jquery.js:2)
    at Object.fireWith [as resolveWith] (jquery.js:2)
    at l (jquery.js:2)
    at XMLHttpRequest.<anonymous> (jquery.js:2)

 

[john9527]

The log behavior remains the same, although the first two console errors are gone:
Code:

Looks like @Jack Yaz will need to take a look. I'm guessing he replaces the LogStatus page and there's an incompatibility there.