Sending Email fails with "05 May" date/time in header

[alan6854321]

I have a script that sends me an Email on WAN connected (via the wan-event script).

On loading the latest Merlin release, the Email is rejected by my ISP as the date/time in the header is the "05 May" the router has before it connects to ntp (I don't think this has anything to do with the latest release, it's the first reload for about 70 days).

The Email gets delivered fine if I reset the WAN connection later on, and according to the entry in syslog, the failing Email is sent when the time has already been set.

The method I use to send the Email I stole from a thread on here somewhere (I'm not a great script expert), this is a snippet where the Email is sent (it uses parameters set in amtm). The "Email sent" message appears in syslog with a valid date/time.

So.. how does the date/time in the Email header get set?

# ---- OK - lets send it

/usr/sbin/curl -v --url ${PROTOCOL}://${SMTP}:${PORT} \
   --mail-from "$FROM_ADDRESS" --mail-rcpt "$TO_ADDRESS" \
   --user "${USERNAME}:$(/usr/sbin/openssl aes-256-cbc "$emailPwEnc" -d -in "$amtmEMailPswdFile" -pass pass:ditbabot,isoi)" \
   --upload-file "$cemTempEMailContent" \
   $SSL_FLAG --ssl-reqd --crlf >> "$cemTempEMailLogFile" 2>&1

if [ $? -eq 0 ]
then
    rm -f "$cemTempEMailLogFile"
    rm -f "$cemTempEMailContent"
    logger Email sent: $1
else
    logger Email: FAILED to send, see $cemTempEMailLogFile
   fi

The wan-event script has the following, I think it waits for ntp to be set ..

#!/bin/sh
#
# Send Email when the WAN is restored,
# Wait for network to come up first.
#
if [[ $# -gt 1 ]] && [[ $2 == "connected" ]]
then
  ntpclient -h pool.ntp.org -s &> /dev/null
  sleep 5
  /jffs/AGT/scripts/send-wan-connected-email &
fi

 

[rung]

Not sure this will fix your issue, but have you tried the router date feature in amtm? It will set the clock to the last known date time before the ntp server is up and running

 

[alan6854321]

Not sure this will fix your issue, but have you tried the router date feature in amtm? It will set the clock to the last known date time before the ntp server is up and running

Yeah I think it would, but I tried it before and didn't like it - made it difficult to spot the reboot in syslog.

BUT - I think I know what the problem is - my terrible scripting!

The ntpclient command I had in my wan-event script doesn't seem to exist (I guess it did in a previous release?), so it was doing nothing. I thought it was waiting until ntp was set.

I think the Email header was built while the date wasn't yet set and the the curl command actually does retries until the network came up so it looked like the whole thing happened after the date was set.

 

[rung]

Do you mind posting your final working script? I've been having trouble with something similar. Thanks.

 

[alan6854321]

Can anyone tell me what the following two options in scMerlin do?

"Enable NTP boot watchdog script" - I have this disabled
"Enable NTP Ready startup check" - I have this enabled.

 

[alan6854321]

Do you mind posting your final working script? I've been having trouble with something similar. Thanks.

I just deleted the ntpclient command and increased the sleep time to 60 secs.
Works for now until someone tells me how to properly wait until ntp has been set.

 

[thelonelycoder]

So.. how does the date/time in the Email header get set?

Looks like you're missing some header content. Unfortunately, you did not include that portion in your post.
Make sure the Date line is included.

"Date: $(date -R)"

 

[alan6854321]

Looks like you're missing some header content. Unfortunately, you did not include that portion in your post which is unfortunate.
Make sure the Date line is included.

Yeah, I found that line earlier in the script, didn't realize the date was just included with the 'text' of the Email until now.

 

[alan6854321]

Looks like you're missing some header content. Unfortunately, you did not include that portion in your post.
Make sure the Date line is included.

Do you know the correct way to wait until ntp has been set?

 

[thelonelycoder]

Do you know the correct way to wait until ntp has been set?

ntptimer=0
ntptimeout=20
while [ "$(nvram get ntp_ready)" = 0 ] && [ "$ntptimer" -lt "$ntptimeout" ]; do
    ntptimer=$((ntptimer+1))
    sleep 1
done

if [ "$ntptimer" -ge "$ntptimeout" ]; then
    # do something else, NTP is not ready
else
    # continue with script, NTP is set.
fi