In your last code revision, the case pattern "[+/-][0-9]" for "$nvramVal" is incorrect because it causes the function to fail with valid values (e.g. "0" or "1") and to succeed with invalid values (e.g. "-1"), and that's because it requires a digit to have a preceding sign character (plus or minus) which is not required for valid values. The correct case pattern would be "[0-9]" for positive digits, making any negative values invalid (which is based on @Viktor Jaep's current code).
The other revisions look fine, although I still prefer to check for a "No arguments" error at the top of the function (just a minor defensive programming technique that I use in most functions for my own work - YCSMV*).
Bash:
if [ $# -lt 1 ] || [ -z "$1" ]
then
echo "ERROR: No argument(s) provided." >&2
return 1
fiNOTE:
@Viktor Jaep, I don't know the actual range of positive values that are valid for the VPN client state so I just assumed "[0-9]" but you might want to adjust that based on what you know and have observed during your own testing.
*Your Coding Standards May Vary.
At the moment, the script can only monitor and fix one connection at a time. I do have plans in the works to build a new script that will monitor up to 5 different VPN connections. It's still in the works/design phase. Keep your eye out!
