Manage NordVPN recommended servers through addons API page

[kid63]

not seeing that here, clients 1 and 2 loading fine. can you check for console errors in the browser? also screenshots would be useful

Post a copy of

cat /jffs/addons/nvpnmgr.d/config

Edit: I've tested it with a different browser too, but will test again, i've found issues in the console now, will post new.

No prob, here's the daemon-config:

Spoiler

##### VPN Client 1 #####
vpn1_managed=true
vpn1_protocol=UDP
vpn1_type=P2P
vpn1_schenabled=true
vpn1_schdays=*
vpn1_schhours=0,12
vpn1_schmins=0
vpn1_countryname=Germany
vpn1_cityname=Frankfurt
vpn1_countryid=81
vpn1_cityid=2215709
#########################
##### VPN Client 2 #####
vpn2_managed=false
vpn2_protocol=UDP
vpn2_type=Standard
vpn2_schenabled=false
vpn2_schdays=
vpn2_schhours=*
vpn2_schmins=*
vpn2_countryname=
vpn2_cityname=
vpn2_countryid=0
vpn2_cityid=0
#########################
##### VPN Client 3 #####
vpn3_managed=false
vpn3_protocol=UDP
vpn3_type=Standard
vpn3_schenabled=false
vpn3_schdays=
vpn3_schhours=*
vpn3_schmins=*
vpn3_countryname=
vpn3_cityname=
vpn3_countryid=0
vpn3_cityid=0
#########################
##### VPN Client 4 #####
vpn4_managed=false
vpn4_protocol=UDP
vpn4_type=Standard
vpn4_schenabled=false
vpn4_schdays=
vpn4_schhours=*
vpn4_schmins=*
vpn4_countryname=
vpn4_cityname=
vpn4_countryid=0
vpn4_cityid=0
#########################
##### VPN Client 5 #####
vpn5_managed=false
vpn5_protocol=UDP
vpn5_type=Standard
vpn5_schenabled=false
vpn5_schdays=
vpn5_schhours=*
vpn5_schmins=*
vpn5_countryname=
vpn5_cityname=
vpn5_countryid=0
vpn5_cityid=0
#########################

 

[kid63]

The JavaScript exception "x is (not) y" occurs when there was an unexpected type. Oftentimes, unexpected undefined or null values.
Message

TypeError: Unable to get property {x} of undefined or null reference (Edge)
TypeError: "x" is (not) "y" (Firefox)

Examples:
TypeError: "x" is undefined
TypeError: "x" is null
TypeError: "undefined" is not an object
TypeError: "x" is not an object or null
TypeError: "x" is not a symbol

Error type

TypeError.
What went wrong?

There was an unexpected type. This occurs oftentimes with undefined or null values.

Also, certain methods, such as Object.create() or Symbol.keyFor(), require a specific type, that must be provided.
Examples
Invalid cases

// undefined and null cases on which the substring method won't work
var foo = undefined;
foo.substring(1); // TypeError: foo is undefined

var foo = null;
foo.substring(1); // TypeError: foo is null


// Certain methods might require a specific type
var foo = {}
Symbol.keyFor(foo); // TypeError: foo is not a symbol

var foo = 'bar'
Object.create(foo); // TypeError: "foo" is not an object or null

Fixing the issue

To fix null pointer to undefined values, you can use the typeof operator, for example.

if (foo !== undefined) {
  // Now we know that foo is defined, we are good to go.
}

if (typeof foo !== 'undefined') {
  // The same good idea, but don't use this implementation - it can bring problems
  // because of the confusion between truly undefined and undeclared variables.
}

SyntaxError: missing ) after argument list

 

[Jack Yaz]

The JavaScript exception "x is (not) y" occurs when there was an unexpected type. Oftentimes, unexpected undefined or null values.


[CODE]SyntaxError: missing ) after argument list

what line is that on please? as a sanity check, do uf again and then option r to reload country data

 

[kid63]

what line is that on please? as a sanity check, do uf again and then option r to reload country data

Here is your sanity check, will tell u the line asap

Choose an option: r

nvpnmgr: Refreshing NordVPN country data...

nvpnmgr: No changes in NordVPN country data

Press enter to continue...

Edit:

validator.js:1170:33

jquery.js:3:5191

Hope that's ok.

 

[Jack Yaz]

Ah...found an issue in Firefox, hotfix pushed,

Collapsed vpn clients don't seem to render in Firefox, hm

 

[kid63]

Ah...found an issue in Firefox, hotfix pushed,

Collapsed vpn clients don't seem to render in Firefox, hm

Thx a lot Jack

 

[Jack Yaz]

Thx a lot Jack

does it work if you try chrome and/or edge

 

[kid63]

does it work if you try chrome and/or edge

Thx for your efforts Jack.

Edit: All common Browsers ok now.

 

[g1dtf]

Not sure if I'm doing something wrong. I switched to the develop fork by using the command nvpnmgr develop which gave me country and city. However if i use uf to force update it reverts to master fork and I lose country and city options. I then have to issue the nvpnmgr develop command to get back to develop again. Is there something else I need to change to get uf to grab the latest develop commit and not revert to master?

 

[Jack Yaz]

Not sure if I'm doing something wrong. I switched to the develop fork by using the command nvpnmgr develop which gave me country and city. However if i use uf to force update it reverts to master fork and I lose country and city options. I then have to issue the nvpnmgr develop command to get back to develop again. Is there something else I need to change to get uf to grab the latest develop commit and not revert to master?

that's my bad, fixed. next run of

nvpnmgr develop

will stay on the right branch with u/uf

 

[kid63]

that's my bad, fixed. next run of

nvpnmgr develop

will stay on the right branch with u/uf

good to know

 

[Jack Yaz]

Firefox still doesn't work. Thx for your efforts Jack.

Screenshot from Edge and Firefox:

Edit: Edge and Chrome ok now.

tested in chrome and firefox, should be working with latest WebUI page now. not tested with Edge yet.

 

[kid63]

tested in chrome and firefox, should be working with latest WebUI page now. not tested with Edge yet.

Yes, working now. Really thx a lot Jack, all common browsers are working now.
Tested with Chrome, Edge and Firefox.

Would you tell me the reason why Firefox was so special? Just code related?

 

[h0me5k1n]

Tested on ipad... Chrome and safari ok

And android chrome and firefox

 

[Jack Yaz]

Yes, working now. Really thx a lot Jack, all common browsers are working now.
Tested with Chrome, Edge and Firefox.

Would you tell me the reason why Firefox was so special? Just code related?

combination of variable declaration, and my attempts with Fetch API but synchronous. moved back to Ajax and all good

 

[kid63]

combination of variable declaration, and my attempts with Fetch API but synchronous. moved back to Ajax and all good

Thx for explaining.

 

[Jack Yaz]

I think we're closing in on release readiness. Are we feature complete at this point?

thoughts?

 

[kid63]

thoughts?

For my part, yes, mission accomplished, ready for release.

 

[g1dtf]

I know its been mentioned earlier in the thread but is there any further thoughts on having an update now in the webgui to force a recommended server update as is in the cli.

 

[Jack Yaz]

I know its been mentioned earlier in the thread but is there any further thoughts on having an update now in the webgui to force a recommended server update as is in the cli.

pressing apply does that?