MerlinAU MerlinAU v1.3.10 - The Ultimate Firmware Auto-Updater (GNUTON SUPPORT!)

[dave14305]

There are 3 distinct sections. Each of the 2 bottom sections contains its own "Save" button that applies ONLY to that specific section.

What led to that design decision? It’s unlike most of the router UI “design”. All the config (from all addons) needs to be written back to custom_settings.txt every time you save, so I’m curious what you achieve with separate buttons.

 

[ExtremeFiretop]

Oh... I see...

So this "bug" became user not-friendly interface report...

I'll say it became a... "Limitations of a small screen" report

I myself thought it was pretty intuitive when I designed the original interface to have a save for each section.

The thought is to have it similar to how MerlinAU has a main menu and an "Advanced Options" menu both with their own set of options to save.

 

[ExtremeFiretop]

So I’m curious what you achieve with separate buttons.

Honestly it's a fair question coming from another developer such as yourself.

It's just a design choice, the idea behind it is simply to maintain separation of the settings mostly.

 

[dave14305]

Honestly it's a fair question coming from another developer such as yourself.

It's just a design choice, the idea behind it is simply to maintain separation of the settings mostly.

I took a look at the code and I see now that you don’t try to keep your settings in custom_settings.txt, but move them to your own config file. Makes a little bit more sense now.

It would still be friendlier to detect changes in either section and write them out together, but no matter. It’s just nice to see someone publish a new add-on WebUI. Well done!

 

[ExtremeFiretop]

I took a look at the code and I see now that you don’t try to keep your settings in custom_settings.txt, but move them to your own config file. Makes a little bit more sense now.

Exactly; basically this design choice came from early development, it was simply easier to troubleshoot the settings with some level of separation.
These days; I can see the argument both ways honestly. But early on when I was still in the process of piecing together how "it all worked" with the WebUI's; this was easier for me to keep track of everything.

It would still be friendlier to detect changes in either section and write them out together, but no matter. It’s just nice to see someone publish a new add-on WebUI. Well done!

Totally hear the feedback @dave14305 and I appreciate your honesty and you testing this out with us!

 

[dave14305]

I appreciate your honesty and you testing this out with us!

I just wish my router had half the updates that the auto-upgrade tool has.

 

[ExtremeFiretop]

I just wish my router had half the updates that the auto-upgrade tool has.

HAHAHAHA. Love it. All I can say is that Martinski and I don't stop or play to any schedule. I get bored, I start writing code.

 

[ExtremeFiretop]

Hi @maghuro
I believe I found the issue for this report below:

A little thing I noticed right away - when I switched to beta branch, in webui, the "enable automatic f/w update checks" was disabled. On terminal, it was enabled.
To solve this, on terminal, I disabled and enabled again this option, refreshed the webui and then the checkbox was shown correctly enabled.

I opened PR: https://github.com/ExtremeFiretop/MerlinAutoUpdate-Router/pull/418 to resolve it.
In short post upgrade using the "develop" switch, it does not update the value in the settings file; it only adds it:

Running the script a second time after installing the develop actually does set the value; and you would have no issues moving forwards.
This is the same thing as you discovered; which is if you immediately disable and enable the setting it also sets the value; and you would have no issues.

It's not a show stopper by any means; because toggling the setting fixes the bug, loading the script a second time fixes the bug, and even the automated cron job would also fix it.
Still wanted you to know we are on top of the report and a fix should be out later today hopefully. Thanks again!

Testing this specific bug will be only possible by completely uninstalling MerlinAU and reconfiguring from scratch (no saved settings)

 

[ExtremeFiretop]

@maghuro

PR has been merged.

Can be tested again by using the following command:

sh /jffs/scripts/MerlinAU.sh develop

As mentioned in the last reply, to properly test, you would need to downgrade back to the production version of MerlinAU, and delete the settings file... or just uninstall the current version and reconfigure from scratch before using the develop command.

Thanks!

 

[maghuro]

@maghuro

PR has been merged.

Can be tested again by using the following command:

sh /jffs/scripts/MerlinAU.sh develop

As mentioned in the last reply, to properly test, you would need to downgrade back to the production version of MerlinAU, and delete the settings file... or just uninstall the current version and reconfigure from scratch before using the develop command.

Thanks!

Not before doing a Backup(Mon)

Did that, it seems OK now! Thank you for your work

 

[ExtremeFiretop]

Did that, it seems OK now! Thank you for your work

No worries! Happy to hear!