MerlinAU MerlinAU v1.3.8 - The Ultimate Firmware Auto-Updater (GNUTON SUPPORT!)

[visortgw]

Can I get clarification what you mean by "risk indication"
Do you mean like this?

View attachment 62565

This was added in version: 1.1.4 here:

MerlinAU - MerlinAU v1.2.6 - The Ultimate Firmware Auto-Updater (**Thread closed due to age**)

I've just experienced the "high-risk phrases" workflow, and have some gentle suggestions for improvement. I'd prefer if the change-log scan happened before the postponement period. Unfortunately this suggestion would require a complete redesign of the workflow compared to our current method...

www.snbforums.com

Yes, but consider using ALL CAPS (since bold, underline, or the like not available in plaintext files) for text that you highlighted.

 

[ExtremeFiretop]

Yes, but consider using ALL CAPS (since bold, underline, or the like not available in plaintext files) for text that you highlighted.

Currently, if it's plain text it uses asterisk as per the link I sent.

I can add a all caps but we already have a way to flag it when it's plaintext emails and not HTML.

 

[ExtremeFiretop]

I think it is useful to always include the link. I want to read the changelog whether there is a high risk phrase or not.

I'm not sure how you would want this implemented... Do you want a separate email only for the changelogs if changelog verification is enabled?

Or would you want it directly in the update notification email if changelog verification is enabled?

Do you want the entire changelog or just a URL to the changelog?

 

[nlurker]

Just the URL so I can click on it to read the changelog if I want to. It does not have to be related to changelog verification at all.

Just add a line to the New Firmware Update email that says click here to read the changelog. So I don't have go searching for it or read the forum to find it. That is all I am asking for.

 

[ExtremeFiretop]

Just add a line to the New Firmware Update email that says click here to read the changelog. So I don't have go searching for it or read the forum to find it.

Easy peasy, I already have that change ready in my personal version of MerlinAU.

 

[ExtremeFiretop]

MerlinAU 1.3.7 Released!

What's Changed/Fixed?:

NEW FEATURE AND BUG FIX:
PR: [ #364 ]
Enable MerlinAU Script Auto-Updates and Fix Backupmon Catch.

• Include New Auto-Update Option for MerlinAU script.
• Fix Backupmon catch/exit as reported by dorner365 on Github here:
• [BUG] - "flash has been CANCELLED due to a failed backup" but it wasn't cancelled #363

NEW FEATURE:
PR: [ #366 ]
Additions, Improvements & Fixes (Thanks @Martinski4GitHub @Martinski)

• There are now 2 modes of operation to set the cron schedule: Guided & Custom.
  a) The "Menu-Guided Entry" is intended to help users select the MINUTES, HOUR, and DAYS for the cron schedule. Useful for users who are not familiar with the cron scheduling syntax.
  b) The "Custom Input/Entry" is intended for users who already know the cron scheduling syntax and can enter the full "raw" schedule string without much help.
• Added code to synchronize the cron schedule for automatic script updates with the schedule for automatic F/W updates.
• Currently, the check for automatic script updates will be performed daily but 15 minutes before the time when the cron for automatic F/W updates is scheduled. This ensures that the script is always updated first before proceeding to check for automatic F/W updates.
• Fixed code in the cron schedule that allowed setting a cron job to run every minute and/or every hour of the day. Technically, this should not be allowed for the purposes of doing automatic F/W updates.
• (Thanks @Martinski4GitHub @Martinski)

NEW FEATURE AND BUG FIX:
PR: [ #367 ]
Fixes: Cron Schedule Calculations, Changelog Verification, Post-Update Version Comparison

• Fixed Cron Schedule Calculations not able to calculate the next job run time; issues with being unable to handle any day intervals correctly.
• Changelog Verification touchup to sanitize the version suffix and be more forgiving with the matching regex.
• Post-Update Version comparison with Gnuton specifically failing
• Includes the changelog in the update notification email as requested by @nlurker here:
• https://www.snbforums.com/threads/m...auto-updater-gnuton-support.91326/post-935218
• All caps risk phrases when using Plain Text email as requested by @visortgw here:
• https://www.snbforums.com/threads/m...auto-updater-gnuton-support.91326/post-934807

BUG FIX:
PR: [ #368 ]
Improvements & Fixes (Thanks @Martinski4GitHub @Martinski)

• Made improvements in the code that builds the cron schedule string for the automatic script updates to make it more robust.
• Made improvements in the cron schedule validation code & some minor wording changes in the error messages generated when validation fails.
• Fixed bugs when trying to determine if we have a "386" build version in order to select the corresponding changelog URL.

As always, we highly recommend you update ASAP as this includes functional improvements and little bug fixes. Wiki has been updated.
Tested against the latest 3004.388.8_4 and 3006.102.2_2

Significant Screenshots:

 

[maghuro]

So it became true!!! Thanks!!!

A little thing. I'm getting an illegal Instruction when pressing any key only inside advanced options menu, on main router.
This doesn't happen on aimesh node....

I run the script with option "-x":

printf ----------------------------------------------------------\n
----------------------------------------------------------
+ _GetKeypressInput_ Enter selection:
+ local inputStrLenMAX=16 inputString promptStr
+ local charNum inputStrLen keypressCount
+ local theKeySeqCnt maxKeySeqCnt=4 retCode
+ local theKeySeqNum maxKeySeqNum=27251624
+ local offlineModeFlag=false
+ [ -n xSETx ]
+ offlineModeFlag=true
+ [ 1 -eq 0 ]
+ [ -z Enter selection: ]
+ promptStr=Enter selection:
+ charNum=
+ inputString=
+ inputStrLen=0
+ keypressCount=0
+ _ClearKeySeqState_
+ theKeySeqNum=0
+ theKeySeqCnt=0
+ true
+ offlineUpdateFlag=false
+ _ShowInputString_
+ printf \r\033[0KEnter selection:  %s
Enter selection:  + local savedIFS=
+ _GetRawKeypress_
+ local savedSettings
+ stty -g
+ savedSettings=500:5:bf:8a3b:3:1c:7f:15:4:0:1:0:11:13:1a:0:12:f:17:16:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0
+ stty -echo raw
+ dd count=1
            Illegal instruction
                               + echo e
                                       + stty 500:5:bf:8a3b:3:1c:7f:15:4:0:1:0:11:13:1a:0:12:f:17:16:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0
                                                + IFS= theChar=e
+ printf %d 'e
+ charNum=101
+ [ 101 -eq 0 ]
+ [ 101 -eq 10 ]
+ [ 101 -eq 13 ]
+ [ 101 -eq 8 ]
+ [ 101 -eq 127 ]
+ [ 101 -eq 21 ]
+ [ 101 -gt 31 ]
+ [ 101 -lt 127 ]
+ [ 0 -le 16 ]
+ inputString=e
+ inputStrLen=1
+ _ShowInputString_
+ printf \r\033[0KEnter selection:  %s e
Enter selection:  e+ _ClearKeySeqState_
+ theKeySeqNum=0
+ theKeySeqCnt=0
+ true
+ offlineUpdateFlag=false
+ continue
+ _GetRawKeypress_
+ local savedSettings
+ stty -g
+ savedSettings=500:5:bf:8a3b:3:1c:7f:15:4:0:1:0:11:13:1a:0:12:f:17:16:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0
+ stty -echo raw
+ dd count=1

 

[ExtremeFiretop]

So it became true!!! Thanks!!!

A little thing. I'm getting an illegal Instruction when pressing any key only inside advanced options menu, on main router.
This doesn't happen on aimesh node....

I run the script with option "-x":

printf ----------------------------------------------------------\n
----------------------------------------------------------
+ _GetKeypressInput_ Enter selection:
+ local inputStrLenMAX=16 inputString promptStr
+ local charNum inputStrLen keypressCount
+ local theKeySeqCnt maxKeySeqCnt=4 retCode
+ local theKeySeqNum maxKeySeqNum=27251624
+ local offlineModeFlag=false
+ [ -n xSETx ]
+ offlineModeFlag=true
+ [ 1 -eq 0 ]
+ [ -z Enter selection: ]
+ promptStr=Enter selection:
+ charNum=
+ inputString=
+ inputStrLen=0
+ keypressCount=0
+ _ClearKeySeqState_
+ theKeySeqNum=0
+ theKeySeqCnt=0
+ true
+ offlineUpdateFlag=false
+ _ShowInputString_
+ printf \r\033[0KEnter selection:  %s
Enter selection:  + local savedIFS=
+ _GetRawKeypress_
+ local savedSettings
+ stty -g
+ savedSettings=500:5:bf:8a3b:3:1c:7f:15:4:0:1:0:11:13:1a:0:12:f:17:16:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0
+ stty -echo raw
+ dd count=1
            Illegal instruction
                               + echo e
                                       + stty 500:5:bf:8a3b:3:1c:7f:15:4:0:1:0:11:13:1a:0:12:f:17:16:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0
                                                + IFS= theChar=e
+ printf %d 'e
+ charNum=101
+ [ 101 -eq 0 ]
+ [ 101 -eq 10 ]
+ [ 101 -eq 13 ]
+ [ 101 -eq 8 ]
+ [ 101 -eq 127 ]
+ [ 101 -eq 21 ]
+ [ 101 -gt 31 ]
+ [ 101 -lt 127 ]
+ [ 0 -le 16 ]
+ inputString=e
+ inputStrLen=1
+ _ShowInputString_
+ printf \r\033[0KEnter selection:  %s e
Enter selection:  e+ _ClearKeySeqState_
+ theKeySeqNum=0
+ theKeySeqCnt=0
+ true
+ offlineUpdateFlag=false
+ continue
+ _GetRawKeypress_
+ local savedSettings
+ stty -g
+ savedSettings=500:5:bf:8a3b:3:1c:7f:15:4:0:1:0:11:13:1a:0:12:f:17:16:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0
+ stty -echo raw
+ dd count=1

Thanks for reporting. I'm just waking up now, it was a late night sorry for the delay. Starting my day, will check into your message in a moment.

Does it cause you any issues in the advanced menu besides the message? Can you still change options and settings for example?

 

[ExtremeFiretop]

So it became true!!! Thanks!!!

A little thing. I'm getting an illegal Instruction when pressing any key only inside advanced options menu, on main router.
This doesn't happen on aimesh node....

I run the script with option "-x":

printf ----------------------------------------------------------\n
----------------------------------------------------------
+ _GetKeypressInput_ Enter selection:
+ local inputStrLenMAX=16 inputString promptStr
+ local charNum inputStrLen keypressCount
+ local theKeySeqCnt maxKeySeqCnt=4 retCode
+ local theKeySeqNum maxKeySeqNum=27251624
+ local offlineModeFlag=false
+ [ -n xSETx ]
+ offlineModeFlag=true
+ [ 1 -eq 0 ]
+ [ -z Enter selection: ]
+ promptStr=Enter selection:
+ charNum=
+ inputString=
+ inputStrLen=0
+ keypressCount=0
+ _ClearKeySeqState_
+ theKeySeqNum=0
+ theKeySeqCnt=0
+ true
+ offlineUpdateFlag=false
+ _ShowInputString_
+ printf \r\033[0KEnter selection:  %s
Enter selection:  + local savedIFS=
+ _GetRawKeypress_
+ local savedSettings
+ stty -g
+ savedSettings=500:5:bf:8a3b:3:1c:7f:15:4:0:1:0:11:13:1a:0:12:f:17:16:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0
+ stty -echo raw
+ dd count=1
            Illegal instruction
                               + echo e
                                       + stty 500:5:bf:8a3b:3:1c:7f:15:4:0:1:0:11:13:1a:0:12:f:17:16:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0
                                                + IFS= theChar=e
+ printf %d 'e
+ charNum=101
+ [ 101 -eq 0 ]
+ [ 101 -eq 10 ]
+ [ 101 -eq 13 ]
+ [ 101 -eq 8 ]
+ [ 101 -eq 127 ]
+ [ 101 -eq 21 ]
+ [ 101 -gt 31 ]
+ [ 101 -lt 127 ]
+ [ 0 -le 16 ]
+ inputString=e
+ inputStrLen=1
+ _ShowInputString_
+ printf \r\033[0KEnter selection:  %s e
Enter selection:  e+ _ClearKeySeqState_
+ theKeySeqNum=0
+ theKeySeqCnt=0
+ true
+ offlineUpdateFlag=false
+ continue
+ _GetRawKeypress_
+ local savedSettings
+ stty -g
+ savedSettings=500:5:bf:8a3b:3:1c:7f:15:4:0:1:0:11:13:1a:0:12:f:17:16:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0
+ stty -echo raw
+ dd count=1

Can you run:

which dd

and also:

type dd

on the primary router please and report the output?

 

[maghuro]

Thanks for reporting. I'm just waking up now, it was a late night sorry for the delay. Starting my day, will check into your message in a moment.

Does it cause you any issues in the advanced menu besides the message? Can you still change options and settings for example?

It shows the error, but the option is written and on enter press it continues as nothing happened.
However every time I type something, on that particular menu, the error is shown...

adminGT-AX6000/tmp/home/root type dd
dd is /opt/bin/dd

 

[ExtremeFiretop]

@maghuro

Can you try the developer version of MerlinAU and report back?

sh MerlinAU.sh develop

 

[visortgw]

@maghuro

Can you try the developer version of MerlinAU and report back?

sh MerlinAU.sh develop

That should be sh /jffs/scripts/MerlinAU.sh develop.

The developer version does not break my installation, which was fully functional on the stable branch. Might we get to test the MerlinAU(AU) feature soon?

 

[ExtremeFiretop]

That should be sh /jffs/scripts/MerlinAU.sh develop.

Correct, I was running from the scripts directory, haha

The developer version does not break my installation, which was fully functional on the stable branch. Might we get to test the MerlinAU(AU) feature soon?

Assuming it resolved his issue! Seems maybe an issue related to priority, Martinski made a change to prioritize the built in binaries.

 

[maghuro]

@maghuro

Can you try the developer version of MerlinAU and report back?

sh MerlinAU.sh develop

I didn't read the commits on the develop branch, but whathever you changed, it solved the issue!

Thank you so much

 

[maghuro]

Correct, I was running from the scripts directory, haha



Assuming it resolved his issue! Seems maybe an issue related to priority, Martinski made a change to prioritize the built in binaries.

It was indeed! Just read the commit, and it really was a priorities issue! Thanks for your prompt fix.

Was wondering... why did I have this issue on main router and not on aimesh node?

 

[ExtremeFiretop]

Was wondering... why did I have this issue on main router and not on aimesh node?

I'll just copy what Martinski said as I think he explained it best:

"The actual root cause is that the current default setup in Entware is to give top priority to Entware binaries in the PATH environment variable so those binaries get called first over the built-in binaries, hence the issues reported.
This affects all Entware utilities installed but, as mentioned, the issues come up only when the behavior is different between the native & the external binary."

Basically whatever entware binary is on the main router is causing this, since the behavior is different than the built in binary.
On your node; you must not have the same set of entware binaries installed/effecting our script.

This is why I was checking your coreutils version via DM
Thanks for reporting! Version 1.3.8 now released into the wild with the fix to prioritize the built-in binaries.

 

[ExtremeFiretop]

MerlinAU 1.3.8 Released!

What's Changed/Fixed?:

BUG FIX:
PR: [ #371 ]
PATH to list built-in binary paths first.

• Set up PATHto give top priority to built-in binaries.
• This addresses the issue where users have equivalent Entware binaries installed and those get called instead.
• See this post by @maghuro : https://www.snbforums.com/threads/merlinau-v1-3-7-the-ultimate-firmware-auto-updater-gnuton-support.91326/page-3#post-936128
• (Thanks @Martinski4GitHub @Martinski)

As always, we highly recommend you update ASAP as this includes functional improvements and little bug fixes.
Tested against the latest 3004.388.8_4 and 3006.102.2_2

Significant Screenshots:

Thanks!

 

[visortgw]

MerlinAU(AU) works as designed. I couldn't wait until 23:45 so I launched the MerlinAU from the command line with the checkupdates argument. Updated to v1.3.8 without a hitch. Nine other routers are set to update overnight...

 

[ExtremeFiretop]

MerlinAU(AU) works as designed. I couldn't wait until 23:45 so I launched the MerlinAU from the command line with the checkupdates argument. Updated to v1.3.8 without a hitch. Nine other routers are set to update overnight...

Fantastic news! Our implemented actually doesn't require the checkupdates argument.

If you just run MerlinAU normally (without the checkupdates argument) it should auto update anyways as long as it's enabled.

And of course, as you mentioned the cron job tonight will also do the same thing for any other instances of the script automatically.

I'm looking forwards to hearing how it works for all your routers tomorrow! Version 1.3.7 should be the last one you need to do manually for all those routers hahaha!

 

[visortgw]

Fantastic news! Our implemented actually doesn't require the checkupdates argument.

If you just run MerlinAU normally (without the checkupdates argument) it should auto update anyways as long as it's enabled.

And of course, as you mentioned the cron job tonight will also do the same thing for any other instances of the script automatically.

I'm looking forwards to hearing how it works for all your routers tomorrow! Version 1.3.7 should be the last one you need to do manually for all those routers hahaha!

I enabled AU for all of those routers -- cron should kick off automatically at 23:45!