vnStat vnStat on Merlin 386.14 missing scrollbar bug

[Tarek Yag]

Hi All,

I already know that @Jack Yaz already updated his scripts for the missing vertical scrollbar (bug) which was newly introduced with Merlin 386.14 firmware for AC models. And I'm looking forward him merging these fixes in the master branches of his respective scripts and the same for other developers.

But weird enough for me, I didn't find anyone reporting on this forum the same (bug) with vnStat script, which is developed by @dev_null
I have RT-AC68U running official Asuswrt Merlin 386.14, and vnStat version 2.0.5
Please note that I tested both master and develop branches, and both have the exact same issue. Any update on this issue would be very much appreciated!

Kindly,

 

[Martinski]

...
But weird enough for me, I didn't find anyone reporting on this forum the same (bug) with vnStat script, which is developed by @dev_null
I have RT-AC68U running official Asuswrt Merlin 386.14, and vnStat version 2.0.5
Please note that I tested both master and develop branch, and both have the exact same issue. Any update on this issue would be very much appreciated!

I've submitted a pull request to @dev_null's GitHub repository to address the "missing scrollbar" issue when the webGUI page is loaded on the 386.14 F/W version.

Here's a screenshot showing the fix:

FYI.

 

[Tarek Yag]

This is great @Martinski, and thanks for submitting pull requests to all the scripts. I really highly appreciate your work.
So, I guess I'll have to report another bug which is preventing me from reaching version 2.0.6, the one you fixed the bug at!
I'm unable to get version 2.0.6 through normal update methods, in both stable and develop branches!!!
Please check the attached screenshots ordered by time already. And advice me what to do or how to solve the issue.

 

[Tarek Yag]

Additionally, and strangely enough, I have a somewhat similar problem with scMerlin script. When updating to the latest stable version it downloads the correct current version (2.5.6). But, when updating to the latest develop version, it doesn't recognize the version number, showing () in the terminal and N/A on the webpage!! Screenshots attached.
Although, after each update (stable and develop), the script still shows the correct version number (2.5.6) in the script's main menu in terminal only.
Moreover, the vertical scrollbar is available with both branches at the script's main web page, but not at the sitemap page!!

 

[Tarek Yag]

FYI, I have the latest versions of everything installed on my router. Here's a screenshot from my AMTM script.

Side note: MD5 difference for VPN Routing script is because I edited the script file only, as it can't get installed on my router using the original script file. That's because it checks for OpenVPN clients 3, 4, and 5 which are not present in RT-AC68U, and when it does that, the script never finishes! @Ranger802004

The fix in short is that I delete all lines related to the missing OpenVPN clients, where the script gets all system parameters. The first line for OVPNC3 is at line #4564 down till the last line for OVPNC5.
Starting line number is specific for the latest version of the script (2.1.3), as I used no other version that this.

 

[Martinski]

...
I'm unable to get version 2.0.6 through normal update methods, in both stable and develop branches!!!
...

The PR has *not* yet been merged. You need to wait for @dev_null to review and merge the code into his "official" repository, and only then the new 2.0.6 version would be available to everyone.

Additionally, and strangely enough, I have a somewhat similar problem with scMerlin script. When updating to the latest stable version it downloads the correct current version (2.5.6). But, when updating to the latest develop version, it doesn't recognize the version number, showing () in the terminal and N/A on the webpage!!
...
Moreover, the vertical scrollbar is available with both branches at the script's main web page, but not at the sitemap page!!

The issues WRT making update requests from the 'develop' branch & the missing scrollbar on the "Sitemap" webpage have been addressed on the latest scMerlin 2.5.7 version:

scMerlin - scMerlin 2.5.8 - Service and script control menu for Asuswrt-Merlin, October 20, 2024

Release Notes for the scMerlin 2.5.6 version now available [2024-June-30]: 1) FIXED code to get the correct temperatures on the webGUI for the "GT-BE98_PRO" router. 2) Some code improvements.

www.snbforums.com

 

[Tarek Yag]

The PR has *not* yet been merged. You need to wait for @dev_null to review and merge the code into his "official" repository

This makes sense now, so 2.0.6 is not available yet in both stable and develop branches. I misunderstood how the pull request works, now it's clear.
Let's hope @dev_null would be available soon to merge the fix. Thank you!

Thank you again for addressing these two issues in scMerlin, I just updated it and the missing scrollbar on the Sitemap page got fixed indeed.

I've got one last issue to report for scMerlin, the "NTP Ready startup check" is not working in the latest firmware, even if the option is set to "No" which disables the check. Although, it's working now on my DSL-AC68U using gnuton's firmware version 386.12-gnuton1, but it's not on the RT-AC68U. Checking the logs, it still waits for NTP to sync on reboot, even on the newest scMerlin 2.5.7
Any help would be much appreciated.

 

[Martinski]

...
I've got one last issue to report for scMerlin, the "NTP Ready startup check" is not working in the latest firmware, even if the option is set to "No" which disables the check. Although, it's working now on my DSL-AC68U using gnuton's firmware version 386.12-gnuton1, but it's not on the RT-AC68U. Checking the logs, it still waits for NTP to sync on reboot, even on the newest scMerlin 2.5.7

Not enough information & context was provided to know whether there's indeed a problem. The best way to figure out what's happening would be to review the system log messages generated during the reboot.

Keep in mind that the "NTP Ready Startup Check" toggle feature functions as a "conditional" off switch, not an absolute off switch.

This means that when the scMerlin startup call is executed during a reboot, the "NTP Ready Startup Check" is *always* performed, regardless of the toggle switch, when the primary WAN interface is found in a *connected* state. OTOH, the startup check is skipped only when set to DISABLED *and* when the primary WAN interface is *not* in a *connected* state. This was done because the main goal of the feature was to avoid the full 10-minute delay when the check was done in situations where the WAN interface, for some reason, did not get to the *connected* state.

The bottom line is that having the "NTP Ready Startup Check" done during a reboot sequence when the WAN state is *connected* is not a bug and is not necessarily a "bad thing" to happen.

 

[Tarek Yag]

Not enough information & context was provided to know whether there's indeed a problem. The best way to figure out what's happening would be to review the system log messages generated during the reboot.

Keep in mind that the "NTP Ready Startup Check" toggle feature functions as a "conditional" off switch, not an absolute on/off switch.

This explains everything now! I always check my system logs, and when I found no obvious reason behind scMerlin still waiting for NTP sync on boot, I had to report it here.

Indeed, whenever scMerlin waits for NTP sync on my RT-AC68U router, the WAN status is connected, I just didn't know that the feature is not an absolute switch!

Thank you for your extensive explanation, I highly appreciate it!

 

[Tarek Yag]

The PR has *not* yet been merged. You need to wait for @dev_null to review and merge the code into his "official" repository, and only then the new 2.0.6 version would be available to everyone.

Since this is taking too long, and it's unclear when a release would possibly be available, and as I somehow rely on this script. I wanted to make a temporary update to my installation on my router, so I went to the repo at GitHub, then to the Pull Request by @Martinski, and copied the content of vnstat-ui.asp and dn-vnstat.sh to their respective files in my router to get the script updated, and it fixed the missing scrollbar issue successfully.

However, I can't figure out which file to copy the content of vnstat-ui.js to in my router's script installation, as I've got no such file, or a file with a similar name here. Any help would be much appreciated.

 

[dev_null]

I have accepted the changes provided by @Martinski for vnStat on Merlin. Note: I have no device running .14 so I can't test the scrollbar fix.

Apologies but I have been on travel. I will also add a comment to the main thread.

Many thanks to @Martinski

 

[Tarek Yag]

Many thanks to you @dev_null and @Martinski for the updates, and I'm sorry for being a little demanding

I just force updated dn-vnstat and tested it right away. Scrollbar issue is officially fixed!

Best Regards

 

[Martinski]

... and copied the content of vnstat-ui.asp and dn-vnstat.sh to their respective files in my router to get the script updated, and it fixed the missing scrollbar issue successfully.

However, I can't figure out which file to copy the content of vnstat-ui.js to in my router's script installation, as I've got no such file, or a file with a similar name here...

To address your concern and for future reference, the JavaScript code is embedded in the ASP file so for new version update purposes, you need to replace only 2 files: the shell script (dn-vnstat.sh) and the ASP (vnstat-ui.asp).

 

[Tarek Yag]

To address your concern and for future reference

Very much appreciated, I can't thank you enough!!!!